voonhous commented on PR #18201: URL: https://github.com/apache/hudi/pull/18201#issuecomment-5631857794
Another thing that i see this PR doing is that we are isolating a `test-hudi-common` job. This would add one job, a 3-minute build of hudi-common and its two upstream modules, and both JDK runs, about 10 runner-minutes per run, to remove 3 minutes from two jobs that are not on the critical path. Against the two metrics we are measuring, this is a loss on **runner-minutes** and zero on **critical runtime**, so I'd leave it out. The only cheaper variant is dropping hudi-common's JDK 17 run entirely, which saves ~2.4 minutes of runner time at the cost of JDK 17 coverage for a pure-Java module; not worth the coverage question for that little savings. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
