prashantwason opened a new pull request, #19912:
URL: https://github.com/apache/hudi/pull/19912
HoodieIncrementalFileIndex inherits sizeInBytes from HoodieFileIndex, which
returns getTotalCachedFilesSize(). Since incremental reads bypass the base
class file slice cache (using listFileSplits() instead), the cache is always
empty and sizeInBytes returns 0.
When Spark sees sizeInBytes=0, it treats the incremental source as tiny and
selects BroadcastHashJoin for joins involving data derived from it. Spark's
selectivity estimates on filtered subexpressions can drop below
autoBroadcastJoinThreshold (default 10MB), causing broadcast exchanges that
compete with the main scan for executor resources and time out (300s default)
on large pipelines.
In 0.x, IncrementalRelation extended BaseRelation which defaults sizeInBytes
to Long.MaxValue, preventing Spark from broadcasting any subexpression that
included the incremental source.
Fix:
- Add getIncrementalFilesSize() to MergeOnReadIncrementalRelation trait,
implemented in V1 and V2 by summing file sizes from affectedFilesInCommits
(commit metadata, no storage I/O).
- Add hoodie.datasource.read.incr.reportMaxFileSize config (default true).
When enabled, sizeInBytes returns Long.MaxValue matching pre-1.0 behavior. When
disabled, returns actual file size from commit metadata.
- Add safety net in HoodieFileIndex.sizeInBytes: return Long.MaxValue when
getTotalCachedFilesSize is 0 even with HoodieSparkSessionExtension enabled,
preventing any FileIndex subclass from reporting size=0.
### Describe the issue this Pull Request addresses
<!-- Either describe the issue inline here with motivation behind the
changes
(or) link to an issue by including `Closes #<issue-number>` for
context.
If this PR includes changes to the storage format, public APIs,
or has breaking changes, use `!` (e.g., feat!: ...) -->
### Summary and Changelog
<!-- Short, plain-English summary of what users gain or what changed in
behavior.
Followed by a detailed log of all the changes. Highlight if any code
was copied. -->
### Impact
<!-- Describe any public API or user-facing feature change or any
performance impact. -->
### Risk Level
<!-- Accepted values: none, low, medium or high. Other than `none`, explain
the risk.
If medium or high, explain what verification was done to mitigate the
risks. -->
### Documentation Update
<!-- Describe any necessary documentation update if there is any new
feature, config, or user-facing change. If not, put "none".
- The config description must be updated if new configs are added or the
default value of the configs are changed.
- Any new feature or user-facing change requires updating the Hudi website.
Please follow the
[instruction](https://hudi.apache.org/contribute/developer-setup#website)
to make changes to the website. -->
### Contributor's checklist
- [ ] Read through [contributor's
guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Enough context is provided in the sections above
- [ ] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
