hudi-agent commented on code in PR #19853:
URL: https://github.com/apache/hudi/pull/19853#discussion_r4007122782
##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/procedures/HoodieProcedureFilterUtils.scala:
##########
@@ -357,10 +366,31 @@ object HoodieProcedureFilterUtils {
}
case _ => unresolvedFunc
}
+ resolveOrFallback(hardcodedResolved, unresolvedFunc, sparkSession)
}
- // Third pass: handle type coercion for numeric comparisons
- functionResolved.transformUp {
+ // Third pass: unwrap any RuntimeReplaceable the parser emitted directly
(ILIKE parses straight
+ // to ILike, never through an UnresolvedFunction the second pass would
route through the
+ // registry) to its real, evaluable replacement, then handle type coercion
for numeric
+ // comparisons.
+ applyHudiWideningRules(unwrapRuntimeReplaceable(functionResolved))
Review Comment:
🤖 nit: this is the exact same
`applyHudiWideningRules(unwrapRuntimeReplaceable(...))` composition that
`finalizeRegistryResolution` wraps below — could you call that helper here too
(maybe renamed to something neutral like `unwrapAndWiden`), so the two call
sites visibly share one step instead of one being inlined and the other named?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
