[GitHub] [hudi] n3nash commented on a change in pull request #2754: [HUDI-1751] Remove irrelevant properties from passing to kafkaConsumer which in turn prints lot of warn logs

[GitBox]

n3nash commented on a change in pull request #2754:
URL: https://github.com/apache/hudi/pull/2754#discussion_r607547703



##########
File path: 
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/KafkaOffsetGen.java
##########
@@ -173,9 +173,11 @@ public KafkaOffsetGen(TypedProperties props) {
     this.props = props;
 
     kafkaParams = new HashMap<>();
-    for (Object prop : props.keySet()) {
+    props.keySet().stream().filter(prop -> {

Review comment:
       @li36909 Okay, I see. The current title makes sense to me now. Can you 
leave the above comment you made in the code as to why we are "removing the 
hoodie properties" ? Once that is done and the CI is green, we can land this. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org