yihua opened a new pull request, #19964:
URL: https://github.com/apache/hudi/pull/19964

   ### Describe the issue this Pull Request addresses
   
   issue: #19750
   
   #19751 fixed the escaping but only added unit tests on 
`PartitionPathEncodeUtils.escapeFileName`. Nothing exercises partitioned RLI 
end to end on a dotted partition column, so a regression in the file-id or 
log-file-name path would not be caught.
   
   ### Summary and Changelog
   
   Adds 
`TestRecordLevelIndex#testPartitionedRecordLevelIndexWithDotInHiveStylePartitionColumn`:
 writes a COW table partitioned on the nested field `fare.currency` with 
hive-style partitioning, then asserts the partitioned record index resolves 
every key in the `fare.currency=USD` partition, both after the initial insert 
and after an upsert.
   
   Verified non-vacuous: with the `escapeFileName` change from #19751 reverted 
the test fails on the first write (the unescaped dot makes the record-index log 
file name unparseable, so `record_index` is not recognized among the inflight 
metadata partitions); with it in place the test passes.
   
   Coverage is deliberately limited to the dotted column name, matching the 
scope of the fix. Dotted partition values, nested hive-style paths and 
non-hive-style dotted paths remain covered only by the unit assertions in 
`TestPartitionPathEncodeUtils`.
   
   ### Impact
   
   None. Test-only.
   
   ### Risk Level
   
   none
   
   ### Documentation Update
   
   none
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Enough context is provided in the sections above
   - [ ] Adequate tests were added if applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to