voonhous commented on PR #19985: URL: https://github.com/apache/hudi/pull/19985#issuecomment-5713782885
Maybe let me share what the problem is. 1. We moved Trino code to Hudi repo and compiled against Trino-483. 2. Trino is on 484-SNAPSHOT 3. They changed their CacheKeyProvider API in 484-SNAPSHOT (Refer to error below) 4. We are in a chicken-egg problem 5. In order for our Shim changes (i.e. Trino repo change to accept jar + have tests running on their end - which was 6. Trino's requirement), we need our Jar to be compliant with 484-SNAPSHOT API 7. However, Apache release rules state that we cannot pin against a floating version, it must be a hard released version. 8. So, we need Trino-484 (which is not released) and they Trino has no ETA on when they want to do a release for 484. 9. Trino side needs our jar to be workable before they can merge our changes in 10. So, the solution is to make our code forward compatible by removing the `CacheKeyProvider` implementation on our end so it falls back to Trino caching logic. 11. Performance degradation is not confirmed yet until we run benchmarks. But this will at least unblock Trino side work. ``` package io.trino.spi.cache does not exist cannot find symbol: class CacheKey cannot find symbol: method locationKey(io.trino.filesystem.Location) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
