linliu-code commented on PR #19979: URL: https://github.com/apache/hudi/pull/19979#issuecomment-5714734903
Closing this unmerged. I opened it against a stale base by mistake: the branch was cut from my fork's master, which was 632 commits behind apache/hudi master, so the diff does not apply to current master and the PR shows as conflicting. More importantly, the change no longer fits current master as written. `HoodieAppendHandle` is now abstract and the delete path has been split: `HoodieInlineLogAppendHandle.writeDelete` builds the `DeleteRecord` with its ordering value, while `HoodieNativeLogAppendHandle.writeDelete` routes through `writer.appendDeleteRecord` so the ordering value is derived inside the writer. Gating only the inline path would compile and pass while leaving the native path unchanged, so this needs a rework rather than a rebase. Issue #19978 stays open: the COW/MOR disagreement it describes is real and unfixed on master. A replacement PR written against the current two-handle structure will follow and close it. Apologies for the churn. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
