voonhous opened a new pull request, #19987:
URL: https://github.com/apache/hudi/pull/19987

   ### Describe the issue this Pull Request addresses
   
   Activating any other profile in the root pom, by `-P` or by property, turns 
off the `activeByDefault` `spark3.5` profile, and `kafka.version` falls back to 
the root default `2.0.0`. That default is below every Kafka version Hudi builds 
with (the Spark profiles set 2.8.1 to 3.9.1):
   
   - The release guide's `mvn -Prelease clean install` fails to compile 
`KafkaAvroSchemaDeserializer`: `kafka-clients` 2.0.0's `Deserializer` has no 
`deserialize(String, Headers, byte[])` overload for its `@Override` (hit while 
cutting 1.2.1 RC2).
   - The Flink CI jobs pass `-Dflink*` without a Spark profile, so they build 
and test `hudi-flink` and `hudi-examples-flink` against `kafka-clients` 2.0.0, 
while the release deploy builds pass `-Dspark3.5` and get 3.4.1.
   
   ### Summary and Changelog
   
   - Root `pom.xml`: `kafka.version` default `2.0.0` -> `3.4.1`, matching 
`spark3.5` like the other root defaults (`hudi.spark.module`, `spark.version`) 
already do, with a comment to keep them in sync.
   
   ### Impact
   
   Builds that select a Spark profile are unchanged. The Flink CI jobs and any 
build that disables the default profiles now use `kafka-clients` 3.4.1 instead 
of 2.0.0.
   
   ### Risk Level
   
   low
   
   The Flink jobs on this PR are the check for the Kafka client change in 
`hudi-flink` and `hudi-examples-flink`.
   
   ### Documentation Update
   
   none
   
   ### Contributor's checklist
   
   - [x] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [x] Enough context is provided in the sections above
   - [ ] Adequate tests were added if applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to