fhan688 commented on code in PR #19948:
URL: https://github.com/apache/hudi/pull/19948#discussion_r4043484459
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/BaseSparkInternalRowReaderContext.java:
##########
@@ -55,7 +56,14 @@ public abstract class BaseSparkInternalRowReaderContext
extends HoodieReaderCont
protected BaseSparkInternalRowReaderContext(StorageConfiguration<?>
storageConfig,
HoodieTableConfig tableConfig,
BaseSparkInternalRecordContext
recordContext) {
- super(storageConfig, tableConfig, Option.empty(), Option.empty(),
recordContext);
+ this(storageConfig, tableConfig, Option.empty(), recordContext);
+ }
+
+ protected BaseSparkInternalRowReaderContext(StorageConfiguration<?>
storageConfig,
Review Comment:
> can we try to extend the existing the constructors instead of adding new
ones?
Thanks, makes sense for the protected base constructor. I’ll extend it with
`instantRangeOpt` and update the internal subclass/test call sites. I’ll keep
the existing Java-friendly constructor on
`SparkFileFormatInternalRowReaderContext`, since Java callers rely on that
overload.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
