voonhous opened a new pull request, #19995:
URL: https://github.com/apache/hudi/pull/19995
TestKeyBasedFileGroupRecordBuffer carried four *WithRecords tests that
duplicate TestStreamingKeyBasedFileGroupRecordBuffer:
readWithEventTimeOrderingWithRecords -> readWithEventTimeOrdering
readWithCommitTimeOrderingWithRecords -> readWithCommitTimeOrdering
readWithCustomPayloadWithRecords -> readWithCustomPayload
readWithCustomMergerWithRecords -> readWithCustomMergerWithRecords
Each pair is identical apart from line wrapping and one inner-class name
being qualified on the key-based side. Both classes are plain siblings
extending BaseTestFileGroupRecordBuffer with no lifecycle hooks, and both reach
the buffer through the same static buildKeyBasedFileGroupRecordBuffer overload
with a non-empty record iterator, which routes to
createStreamingRecordsBufferLoader(). The same production path therefore ran
twice.
Delete the four copies from TestKeyBasedFileGroupRecordBuffer, along with
the eight fixture fields and eight imports they alone used. The six remaining
tests are byte-identical to before.
### Describe the issue this Pull Request addresses
<!-- Either describe the issue inline here with motivation behind the
changes
(or) link to an issue by including `Closes #<issue-number>` for
context.
If this PR includes changes to the storage format, public APIs,
or has breaking changes, use `!` (e.g., feat!: ...) -->
### Summary and Changelog
<!-- Short, plain-English summary of what users gain or what changed in
behavior.
Followed by a detailed log of all the changes. Highlight if any code
was copied. -->
### Impact
<!-- Describe any public API or user-facing feature change or any
performance impact. -->
### Risk Level
<!-- Accepted values: none, low, medium or high. Other than `none`, explain
the risk.
If medium or high, explain what verification was done to mitigate the
risks. -->
### Documentation Update
<!-- Describe any necessary documentation update if there is any new
feature, config, or user-facing change. If not, put "none".
- The config description must be updated if new configs are added or the
default value of the configs are changed.
- Any new feature or user-facing change requires updating the Hudi website.
Please follow the
[instruction](https://hudi.apache.org/contribute/developer-setup#website)
to make changes to the website. -->
### Contributor's checklist
- [ ] Read through [contributor's
guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Enough context is provided in the sections above
- [ ] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
