shangxinli commented on PR #19868:
URL: https://github.com/apache/hudi/pull/19868#issuecomment-5742521854
> ⚠️ 🤖 _This review was generated by an AI agent and may contain mistakes.
Please verify any suggestions before applying._
>
> Thanks for the follow-up revisions! This round consolidates the
compaction-backlog gauge into a single `reportDeltaCommitsSinceLastCompaction`
helper invoked from the `finally` block of `performTableServices`, reloading
the MDT timeline under the `metrics.ifPresent` guard, and reworks the tests to
share a `writerForTableServices` helper with real `ActiveTimelineV2` instances.
I traced the `CompactionUtils` path, the exception handling around the reload,
and the production callers, and the logic holds up for the empty-timeline,
failure, and reloaded-timeline cases. No issues flagged from this automated
pass — a Hudi committer or PMC member can take it from here for a final review.
>
> cc @yihua
Done — extracted a qualifiedMetricName helper and used it for all three
names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
