prashantwason commented on PR #20029: URL: https://github.com/apache/hudi/pull/20029#issuecomment-5884079537
Thanks @yihua for the detailed review. Agreed on all points; reworked in 0c24ffd: - `shortName()` now returns the base file format short name (`parquet` / `orc` from the table's base file format; `parquet` for multiple base file formats), restoring the pre-#13632 behavior on every read path (DataFrame API, Spark Connect, Thrift) without touching session state. - Dropped the `HoodieNestedPredicatePushdownConfig` optimizer rule entirely. - Fixed the test to assert the nested predicates (`EqualTo(item.name,a1)`, `GreaterThan(item.price,5)`) appear in `PushedFilters` rather than relying on `PushedFilters` being non-empty (which the inferred `IsNotNull(item)` satisfies on master), with a negative leg (empty allowlist), plus a unit test pinning `shortName()` per base file format. - Added a schema-on-read leg with a renamed nested column to verify the filter is rewritten to the file-side name. Will backport to release-1.1.x / release-1.2.x once this lands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
