hudi-agent commented on code in PR #20187:
URL: https://github.com/apache/hudi/pull/20187#discussion_r4163294834


##########
hudi-hadoop-common/src/main/java/org/apache/parquet/avro/HoodieAvroParquetReaderBuilder.java:
##########
@@ -36,7 +36,7 @@
  */
 public class HoodieAvroParquetReaderBuilder<T> extends 
ParquetReader.Builder<T> {
 
-  private GenericData model = null;
+  private GenericData model = GenericData.get();

Review Comment:
   🤖 Heads-up: with a plain `GenericData` model, parquet-avro returns array 
fields as `GenericData.Array` instead of `java.util.ArrayList`, so "results are 
unchanged" isn't quite true. I couldn't find any consumer that depends on 
`ArrayList`. Could you confirm, and maybe add an array field to the new test?
   
   <sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag 
quality.</i></sub>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to