txwyy123 commented on PR #19930: URL: https://github.com/apache/hudi/pull/19930#issuecomment-5986307101
@linliu-code @yihua Gentle follow-up on the revised patch. It now uses the existing HBase-written GZ fixture and comprehensive TestHFileReader checks rather than adding a separate test class. The fixture has gzip-like checksum tails covering both the invalid-DEFLATE and truncated-stream cases; the compressed payloads and headers are unchanged. The production comment also explains why both the compressed-input and uncompressed-output limits are needed. Azure CI reports success for the current head, and Codecov reports full coverage of the modified coverable lines. The substantive GitHub test jobs passed as well, although the check rollup still includes earlier cancelled validation jobs. The current patch does not add the bot-suggested decompressed-length/header-bounds validation or change checksum-buffer sizing. Would you consider any of those required for this targeted over-read fix, or better handled separately? When you have a chance, could you please review the updated test approach and let me know whether anything else is needed? Happy to make further adjustments. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
