codope commented on code in PR #20183: URL: https://github.com/apache/hudi/pull/20183#discussion_r4201931789
########## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/HoodieFileGroupReaderBasedFileFormat.scala: ########## Review Comment: nit: `detectVectorColumnsCached` reads `cachedVectorDetection` twice, so a concurrent scan on the same relation can swap it between the check and the read. Reading it into a local `val` first avoids that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
