This is an automated email from the ASF dual-hosted git repository.
yihua pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hudi.git
The following commit(s) were added to refs/heads/master by this push:
new 7e4c94434813 chore: fix javadoc and compiler warnings flagged in CI
(#20215)
7e4c94434813 is described below
commit 7e4c944348137fb3ebb4805b331d1c90a9683efe
Author: Y Ethan Guo <[email protected]>
AuthorDate: Tue Oct 6 19:16:28 2026 -0700
chore: fix javadoc and compiler warnings flagged in CI (#20215)
---
.../hudi/cli/utils/SparkTempViewProvider.java | 2 +-
.../apache/hudi/config/HoodieClusteringConfig.java | 2 +
.../hudi/client/utils/SparkValidatorUtils.java | 2 -
.../table/action/commit/TestUpsertPartitioner.java | 4 +-
.../hudi/testutils/FunctionalTestHarness.java | 1 +
.../org/apache/hudi/common/expression/Literal.java | 2 +-
.../hudi/common/expression/NameReference.java | 2 +-
.../timeline/versioning/v1/ActiveTimelineV1.java | 12 ++++--
.../timeline/versioning/v1/ArchivedTimelineV1.java | 12 ++++--
.../timeline/versioning/v2/ActiveTimelineV2.java | 12 ++++--
.../table/view/FileSystemViewStorageConfig.java | 10 ++---
.../hudi/common/model/TestHoodieWriteStat.java | 8 ++--
.../apache/hudi/common/util/TestBaseFileUtils.java | 8 ++--
.../apache/hudi/util/ImplicitTypeConverter.java | 4 +-
.../org/apache/hudi/util/TestExpressionUtils.java | 14 +++----
.../table/view/TestHoodieTableFileSystemView.java | 6 +--
.../org/apache/hudi/ColumnStatsIndexHelper.java | 20 ++++-----
.../TestColStatsRecordWithMetadataRecord.java | 48 +++++++++++-----------
18 files changed, 94 insertions(+), 75 deletions(-)
diff --git
a/hudi-cli/src/main/java/org/apache/hudi/cli/utils/SparkTempViewProvider.java
b/hudi-cli/src/main/java/org/apache/hudi/cli/utils/SparkTempViewProvider.java
index 9cb651e4b65f..0620117e5a6e 100644
---
a/hudi-cli/src/main/java/org/apache/hudi/cli/utils/SparkTempViewProvider.java
+++
b/hudi-cli/src/main/java/org/apache/hudi/cli/utils/SparkTempViewProvider.java
@@ -81,7 +81,7 @@ public class SparkTempViewProvider implements
TempViewProvider {
DataType headerDataType = getDataType(rows.get(0).get(i));
structType =
structType.add(DataTypes.createStructField(headersNoSpaces.get(i),
headerDataType, true));
}
- List<Row> records = rows.stream().map(row ->
RowFactory.create(row.toArray(new Comparable[row.size()])))
+ List<Row> records = rows.stream().map(row ->
RowFactory.create(row.toArray()))
.collect(Collectors.toList());
Dataset<Row> dataset = this.sqlContext.createDataFrame(records,
structType);
dataset.createOrReplaceTempView(tableName);
diff --git
a/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieClusteringConfig.java
b/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieClusteringConfig.java
index fd713d73bb00..b6091c60dbe1 100644
---
a/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieClusteringConfig.java
+++
b/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieClusteringConfig.java
@@ -306,6 +306,7 @@ public class HoodieClusteringConfig extends HoodieConfig {
* @deprecated this setting has no effect. Please refer to clustering
configuration, as well as
* {@link #LAYOUT_OPTIMIZE_STRATEGY} config to enable advanced record layout
optimization strategies
*/
+ @Deprecated
public static final ConfigProperty LAYOUT_OPTIMIZE_ENABLE = ConfigProperty
.key(LAYOUT_OPTIMIZE_PARAM_PREFIX + "enable")
.defaultValue(false)
@@ -381,6 +382,7 @@ public class HoodieClusteringConfig extends HoodieConfig {
/**
* @deprecated this setting has no effect
*/
+ @Deprecated
public static final ConfigProperty LAYOUT_OPTIMIZE_DATA_SKIPPING_ENABLE =
ConfigProperty
.key(LAYOUT_OPTIMIZE_PARAM_PREFIX + "data.skipping.enable")
.defaultValue(true)
diff --git
a/hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/utils/SparkValidatorUtils.java
b/hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/utils/SparkValidatorUtils.java
index 233f622beff6..ae2c61b0e3db 100644
---
a/hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/utils/SparkValidatorUtils.java
+++
b/hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/utils/SparkValidatorUtils.java
@@ -102,8 +102,6 @@ public class SparkValidatorUtils {
return Stream.of(validator);
} catch (ClassNotFoundException e) {
throw new HoodieValidationException("Cannot find validator
class: " + validatorClass, e);
- } catch (ReflectiveOperationException e) {
- throw new HoodieValidationException("Failed to instantiate
validator: " + validatorClass, e);
}
})
.collect(Collectors.toList());
diff --git
a/hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/action/commit/TestUpsertPartitioner.java
b/hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/action/commit/TestUpsertPartitioner.java
index 408a9569fb3f..9bc3c99c48f8 100644
---
a/hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/action/commit/TestUpsertPartitioner.java
+++
b/hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/action/commit/TestUpsertPartitioner.java
@@ -143,12 +143,12 @@ public class TestUpsertPartitioner extends
HoodieClientTestBase {
float bucket0Weight = 0.2f;
InsertBucketCumulativeWeightPair pair = insertBuckets.remove(0);
pair.getKey().weight = bucket0Weight;
- pair.setValue(new Double(bucket0Weight));
+ pair.setValue(Double.valueOf(bucket0Weight));
insertBuckets.add(0, pair);
InsertBucketCumulativeWeightPair pair1 = insertBuckets.remove(1);
pair1.getKey().weight = 1 - bucket0Weight;
- pair1.setValue(new Double(1));
+ pair1.setValue(Double.valueOf(1));
insertBuckets.add(1, pair1);
Map<Integer, Integer> partition2numRecords = new HashMap<Integer,
Integer>();
diff --git
a/hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/testutils/FunctionalTestHarness.java
b/hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/testutils/FunctionalTestHarness.java
index 9af15bc0f2ff..e1eb82398f16 100644
---
a/hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/testutils/FunctionalTestHarness.java
+++
b/hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/testutils/FunctionalTestHarness.java
@@ -62,6 +62,7 @@ import static
org.apache.hudi.common.testutils.HoodieTestUtils.RAW_TRIPS_TEST_NA
/**
* @deprecated Deprecated. Use {@link SparkClientFunctionalTestHarness}
instead.
*/
+@Deprecated
public class FunctionalTestHarness implements SparkProvider, DFSProvider,
HoodieMetaClientProvider, HoodieWriteClientProvider {
protected static transient SparkSession spark;
diff --git
a/hudi-common/src/main/java/org/apache/hudi/common/expression/Literal.java
b/hudi-common/src/main/java/org/apache/hudi/common/expression/Literal.java
index ce54222197ff..40933339dbda 100644
--- a/hudi-common/src/main/java/org/apache/hudi/common/expression/Literal.java
+++ b/hudi-common/src/main/java/org/apache/hudi/common/expression/Literal.java
@@ -33,7 +33,7 @@ import java.util.UUID;
@AllArgsConstructor
@Getter
-@EqualsAndHashCode
+@EqualsAndHashCode(callSuper = false)
public class Literal<T> extends LeafExpression {
public static <V> Literal from(V value) {
diff --git
a/hudi-common/src/main/java/org/apache/hudi/common/expression/NameReference.java
b/hudi-common/src/main/java/org/apache/hudi/common/expression/NameReference.java
index f0cb9c507a8c..e3428b05d30d 100644
---
a/hudi-common/src/main/java/org/apache/hudi/common/expression/NameReference.java
+++
b/hudi-common/src/main/java/org/apache/hudi/common/expression/NameReference.java
@@ -26,7 +26,7 @@ import lombok.Getter;
@AllArgsConstructor
@Getter
-@EqualsAndHashCode
+@EqualsAndHashCode(callSuper = false)
public class NameReference extends LeafExpression {
private final String name;
diff --git
a/hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/v1/ActiveTimelineV1.java
b/hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/v1/ActiveTimelineV1.java
index d3ecd8225172..ba0c6eef2010 100644
---
a/hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/v1/ActiveTimelineV1.java
+++
b/hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/v1/ActiveTimelineV1.java
@@ -47,7 +47,6 @@ import org.apache.hudi.storage.HoodieInstantWriter;
import org.apache.hudi.storage.HoodieStorage;
import org.apache.hudi.storage.StoragePath;
-import lombok.NoArgsConstructor;
import lombok.extern.slf4j.Slf4j;
import java.io.IOException;
@@ -62,8 +61,6 @@ import java.util.stream.Stream;
import static
org.apache.hudi.common.table.timeline.TimelineUtils.getHoodieInstantWriterOption;
-// no-arg constructor is for serialization and de-serialization only;
@Deprecated marks it as such
-@NoArgsConstructor(onConstructor_ = @Deprecated)
@Slf4j
public class ActiveTimelineV1 extends BaseTimelineV1 implements
HoodieActiveTimeline {
@@ -102,6 +99,15 @@ public class ActiveTimelineV1 extends BaseTimelineV1
implements HoodieActiveTime
this(metaClient,
Collections.unmodifiableSet(VALID_EXTENSIONS_IN_ACTIVE_TIMELINE),
applyLayoutFilter);
}
+ /**
+ * For serialization and de-serialization only.
+ *
+ * @deprecated
+ */
+ @Deprecated
+ public ActiveTimelineV1() {
+ }
+
/**
* This method is only used when this object is deserialized in a spark
executor.
*
diff --git
a/hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/v1/ArchivedTimelineV1.java
b/hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/v1/ArchivedTimelineV1.java
index 0d8ecb7b3a8f..ebda07e57378 100644
---
a/hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/v1/ArchivedTimelineV1.java
+++
b/hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/v1/ArchivedTimelineV1.java
@@ -28,7 +28,6 @@ import org.apache.hudi.common.util.Option;
import org.apache.hudi.storage.StoragePath;
import org.apache.hudi.storage.StoragePathInfo;
-import lombok.NoArgsConstructor;
import org.apache.avro.generic.GenericRecord;
import org.apache.avro.generic.IndexedRecord;
import org.slf4j.Logger;
@@ -54,8 +53,6 @@ import java.util.stream.Collectors;
import static
org.apache.hudi.common.table.timeline.TimelineUtils.getInputStreamOptionLegacy;
-// no-arg constructor is for serialization and de-serialization only
-@NoArgsConstructor(onConstructor_ = @Deprecated)
public class ArchivedTimelineV1 extends BaseTimelineV1 implements
HoodieArchivedTimeline, HoodieInstantReader {
private static final String HOODIE_COMMIT_ARCHIVE_LOG_FILE_PREFIX =
"commits";
private static final String ACTION_TYPE_KEY = "actionType";
@@ -158,6 +155,15 @@ public class ArchivedTimelineV1 extends BaseTimelineV1
implements HoodieArchived
this(metaClient, null, new LogFileFilter(logFiles), state);
}
+ /**
+ * For serialization and de-serialization only.
+ *
+ * @deprecated
+ */
+ @Deprecated
+ public ArchivedTimelineV1() {
+ }
+
@Override
public HoodieInstantReader getInstantReader() {
return this;
diff --git
a/hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/v2/ActiveTimelineV2.java
b/hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/v2/ActiveTimelineV2.java
index 35d39bd29b2a..d609eccb53db 100644
---
a/hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/v2/ActiveTimelineV2.java
+++
b/hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/v2/ActiveTimelineV2.java
@@ -50,7 +50,6 @@ import org.apache.hudi.storage.HoodieInstantWriter;
import org.apache.hudi.storage.HoodieStorage;
import org.apache.hudi.storage.StoragePath;
-import lombok.NoArgsConstructor;
import lombok.extern.slf4j.Slf4j;
import java.io.IOException;
@@ -67,8 +66,6 @@ import java.util.stream.Stream;
import static
org.apache.hudi.common.table.timeline.TimelineUtils.getHoodieInstantWriterOption;
-// no-arg constructor is for serialization and de-serialization only;
@Deprecated marks it as such
-@NoArgsConstructor(onConstructor_ = @Deprecated)
@Slf4j
public class ActiveTimelineV2 extends BaseTimelineV2 implements
HoodieActiveTimeline {
@@ -107,6 +104,15 @@ public class ActiveTimelineV2 extends BaseTimelineV2
implements HoodieActiveTime
this(metaClient,
Collections.unmodifiableSet(VALID_EXTENSIONS_IN_ACTIVE_TIMELINE),
applyLayoutFilter);
}
+ /**
+ * For serialization and de-serialization only.
+ *
+ * @deprecated
+ */
+ @Deprecated
+ public ActiveTimelineV2() {
+ }
+
/**
* This method is only used when this object is deserialized in a spark
executor.
*
diff --git
a/hudi-common/src/main/java/org/apache/hudi/common/table/view/FileSystemViewStorageConfig.java
b/hudi-common/src/main/java/org/apache/hudi/common/table/view/FileSystemViewStorageConfig.java
index c98b41d094e7..049dfe5fa79c 100644
---
a/hudi-common/src/main/java/org/apache/hudi/common/table/view/FileSystemViewStorageConfig.java
+++
b/hudi-common/src/main/java/org/apache/hudi/common/table/view/FileSystemViewStorageConfig.java
@@ -239,33 +239,33 @@ public class FileSystemViewStorageConfig extends
HoodieConfig {
public long getMaxMemoryForPendingCompaction() {
long totalMemory = getLong(SPILLABLE_MEMORY);
- return new Double(totalMemory *
getDouble(SPILLABLE_COMPACTION_MEM_FRACTION))
+ return Double.valueOf(totalMemory *
getDouble(SPILLABLE_COMPACTION_MEM_FRACTION))
.longValue();
}
public long getMaxMemoryForPendingLogCompaction() {
long totalMemory = getLong(SPILLABLE_MEMORY);
- return new Double(totalMemory *
getDouble(SPILLABLE_LOG_COMPACTION_MEM_FRACTION))
+ return Double.valueOf(totalMemory *
getDouble(SPILLABLE_LOG_COMPACTION_MEM_FRACTION))
.longValue();
}
public long getMaxMemoryForBootstrapBaseFile() {
long totalMemory = getLong(SPILLABLE_MEMORY);
long reservedForExternalDataFile =
- new Double(totalMemory * getDouble(BOOTSTRAP_BASE_FILE_MEM_FRACTION))
+ Double.valueOf(totalMemory *
getDouble(BOOTSTRAP_BASE_FILE_MEM_FRACTION))
.longValue();
return reservedForExternalDataFile;
}
public long getMaxMemoryForReplacedFileGroups() {
long totalMemory = getLong(SPILLABLE_MEMORY);
- return new Double(totalMemory * getDouble(SPILLABLE_REPLACED_MEM_FRACTION))
+ return Double.valueOf(totalMemory *
getDouble(SPILLABLE_REPLACED_MEM_FRACTION))
.longValue();
}
public long getMaxMemoryForPendingClusteringFileGroups() {
long totalMemory = getLong(SPILLABLE_MEMORY);
- return new Double(totalMemory *
getDouble(SPILLABLE_CLUSTERING_MEM_FRACTION))
+ return Double.valueOf(totalMemory *
getDouble(SPILLABLE_CLUSTERING_MEM_FRACTION))
.longValue();
}
diff --git
a/hudi-common/src/test/java/org/apache/hudi/common/model/TestHoodieWriteStat.java
b/hudi-common/src/test/java/org/apache/hudi/common/model/TestHoodieWriteStat.java
index f84ca7c026ab..ea4c7cd63c9f 100644
---
a/hudi-common/src/test/java/org/apache/hudi/common/model/TestHoodieWriteStat.java
+++
b/hudi-common/src/test/java/org/apache/hudi/common/model/TestHoodieWriteStat.java
@@ -95,15 +95,15 @@ public class TestHoodieWriteStat {
// Utf8
minMaxValues.add(Pair.of(new Utf8(getUTF8Bytes("abcdec")), new
Utf8(getUTF8Bytes("zyxwvu"))));
// Int
- minMaxValues.add(Pair.of(new Integer(-1000), new Integer(999999)));
+ minMaxValues.add(Pair.of(Integer.valueOf(-1000), Integer.valueOf(999999)));
// Long
- minMaxValues.add(Pair.of(new Long(-100000L), Long.MAX_VALUE));
+ minMaxValues.add(Pair.of(Long.valueOf(-100000L), Long.MAX_VALUE));
// boolean
minMaxValues.add(Pair.of(false, true));
// double
- minMaxValues.add(Pair.of(new Double(0.123), new Double(10.123)));
+ minMaxValues.add(Pair.of(Double.valueOf(0.123), Double.valueOf(10.123)));
// float
- minMaxValues.add(Pair.of(new Float(0.0123), new Float(200.123)));
+ minMaxValues.add(Pair.of(Float.valueOf(0.0123f), Float.valueOf(200.123f)));
// Date
minMaxValues.add(Pair.of(new java.sql.Date(1000 * 60 * 60 * 10), new
java.sql.Date(1000 * 60 * 60 * 60)));
// LocalDate
diff --git
a/hudi-common/src/test/java/org/apache/hudi/common/util/TestBaseFileUtils.java
b/hudi-common/src/test/java/org/apache/hudi/common/util/TestBaseFileUtils.java
index f62a4c4fd8f1..25ad8dfd23f4 100644
---
a/hudi-common/src/test/java/org/apache/hudi/common/util/TestBaseFileUtils.java
+++
b/hudi-common/src/test/java/org/apache/hudi/common/util/TestBaseFileUtils.java
@@ -50,8 +50,8 @@ public class TestBaseFileUtils {
// Step 3: Assertions
assertEquals(PARTITION_PATH, result.getFilePath());
assertEquals(COLUMN_NAME, result.getColumnName());
- assertEquals(Integer.valueOf(1), new
Integer(result.getMinValue().toString()));
- assertEquals(Integer.valueOf(8), new
Integer(result.getMaxValue().toString()));
+ assertEquals(Integer.valueOf(1),
Integer.valueOf(result.getMinValue().toString()));
+ assertEquals(Integer.valueOf(8),
Integer.valueOf(result.getMaxValue().toString()));
assertEquals(1, result.getNullCount());
assertEquals(25, result.getValueCount());
assertEquals(220, result.getTotalSize());
@@ -73,8 +73,8 @@ public class TestBaseFileUtils {
// Step 3: Assertions
assertEquals(PARTITION_PATH, result.getFilePath());
assertEquals(COLUMN_NAME, result.getColumnName());
- assertEquals(Integer.valueOf(1), new
Integer(result.getMinValue().toString()));
- assertEquals(Integer.valueOf(8), new
Integer(result.getMaxValue().toString()));
+ assertEquals(Integer.valueOf(1),
Integer.valueOf(result.getMinValue().toString()));
+ assertEquals(Integer.valueOf(8),
Integer.valueOf(result.getMaxValue().toString()));
assertEquals(1, result.getNullCount());
assertEquals(25, result.getValueCount());
assertEquals(220, result.getTotalSize());
diff --git
a/hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/ImplicitTypeConverter.java
b/hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/ImplicitTypeConverter.java
index 22c4da43dde0..0344340ebe2e 100644
---
a/hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/ImplicitTypeConverter.java
+++
b/hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/ImplicitTypeConverter.java
@@ -61,7 +61,7 @@ public class ImplicitTypeConverter {
if (literal instanceof Long) {
return literal;
} else if (literal instanceof Integer) {
- return new Long((Integer) literal);
+ return Long.valueOf((Integer) literal);
} else {
return Long.valueOf(String.valueOf(literal));
}
@@ -117,7 +117,7 @@ public class ImplicitTypeConverter {
} else if (literal instanceof Long) {
return literal;
} else if (literal instanceof Integer) {
- return new Long((Integer) literal);
+ return Long.valueOf((Integer) literal);
} else {
return
LocalDateTime.parse(String.valueOf(literal)).toInstant(ZoneOffset.UTC).toEpochMilli();
}
diff --git
a/hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/util/TestExpressionUtils.java
b/hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/util/TestExpressionUtils.java
index 2b6b650ad445..d2d733ba80c3 100644
---
a/hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/util/TestExpressionUtils.java
+++
b/hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/util/TestExpressionUtils.java
@@ -109,13 +109,13 @@ class TestExpressionUtils {
List<DataType> dataTypes = ROW_DATA_TYPE_FIELD_NON_NULL.getChildren();
// tests for non-null literals
List<Object> dataList = new ArrayList<>(fields.size());
- dataList.add(new Byte("1")); // f_tinyint
- dataList.add(new Short("2")); // f_smallint
- dataList.add(new Integer("3")); // f_int
- dataList.add(new Long("4")); // f_long
- dataList.add(new Float(5.0)); // f_float
- dataList.add(new Double(6.0)); // f_double
- dataList.add(new Boolean(true)); // f_boolean
+ dataList.add(Byte.valueOf("1")); // f_tinyint
+ dataList.add(Short.valueOf("2")); // f_smallint
+ dataList.add(Integer.valueOf("3")); // f_int
+ dataList.add(Long.valueOf("4")); // f_long
+ dataList.add(Float.valueOf(5.0f)); // f_float
+ dataList.add(Double.valueOf(6.0)); // f_double
+ dataList.add(Boolean.valueOf(true)); // f_boolean
dataList.add(new BigDecimal(3.0)); // f_decimal
dataList.add(getUTF8Bytes("hudi")); // f_bytes
dataList.add("hudi ok"); // f_string
diff --git
a/hudi-hadoop-common/src/test/java/org/apache/hudi/common/table/view/TestHoodieTableFileSystemView.java
b/hudi-hadoop-common/src/test/java/org/apache/hudi/common/table/view/TestHoodieTableFileSystemView.java
index e4decc0d1c14..f1f3437afa13 100644
---
a/hudi-hadoop-common/src/test/java/org/apache/hudi/common/table/view/TestHoodieTableFileSystemView.java
+++
b/hudi-hadoop-common/src/test/java/org/apache/hudi/common/table/view/TestHoodieTableFileSystemView.java
@@ -831,10 +831,10 @@ public class TestHoodieTableFileSystemView extends
HoodieCommonTestHarness {
assertEquals(srcFileStatus.getPath(),
HadoopFSUtils.fromPath(new Path(bootstrapBaseFile.get().getPath())));
assertEquals(srcFileStatus.getModificationTime(),
- new
Long(bootstrapBaseFile.get().getPathInfo().getModificationTime()));
- assertEquals(srcFileStatus.getBlockSize(), new
Long(bootstrapBaseFile.get().getPathInfo().getBlockSize()));
+
Long.valueOf(bootstrapBaseFile.get().getPathInfo().getModificationTime()));
+ assertEquals(srcFileStatus.getBlockSize(),
Long.valueOf(bootstrapBaseFile.get().getPathInfo().getBlockSize()));
assertEquals(srcFileStatus.getLength(),
- new Long(bootstrapBaseFile.get().getPathInfo().getLength()));
+ Long.valueOf(bootstrapBaseFile.get().getPathInfo().getLength()));
assertEquals(srcFileStatus.getIsDir() != null &&
srcFileStatus.getIsDir(),
bootstrapBaseFile.get().getPathInfo().isDirectory());
} else {
diff --git
a/hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/ColumnStatsIndexHelper.java
b/hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/ColumnStatsIndexHelper.java
index 322247c852d8..45ddf09997ef 100644
---
a/hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/ColumnStatsIndexHelper.java
+++
b/hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/ColumnStatsIndexHelper.java
@@ -75,13 +75,13 @@ public class ColumnStatsIndexHelper {
@Nonnull HoodieColumnRangeMetadata<Comparable> colMetadata) {
if (colType instanceof IntegerType) {
return Pair.of(
- new Integer(colMetadata.getMinValue().toString()),
- new Integer(colMetadata.getMaxValue().toString())
+ Integer.valueOf(colMetadata.getMinValue().toString()),
+ Integer.valueOf(colMetadata.getMaxValue().toString())
);
} else if (colType instanceof DoubleType) {
return Pair.of(
- new Double(colMetadata.getMinValue().toString()),
- new Double(colMetadata.getMaxValue().toString())
+ Double.valueOf(colMetadata.getMinValue().toString()),
+ Double.valueOf(colMetadata.getMaxValue().toString())
);
} else if (colType instanceof StringType) {
return Pair.of(
@@ -97,16 +97,16 @@ public class ColumnStatsIndexHelper {
java.sql.Date.valueOf(colMetadata.getMaxValue().toString()));
} else if (colType instanceof LongType) {
return Pair.of(
- new Long(colMetadata.getMinValue().toString()),
- new Long(colMetadata.getMaxValue().toString()));
+ Long.valueOf(colMetadata.getMinValue().toString()),
+ Long.valueOf(colMetadata.getMaxValue().toString()));
} else if (colType instanceof ShortType) {
return Pair.of(
- new Short(colMetadata.getMinValue().toString()),
- new Short(colMetadata.getMaxValue().toString()));
+ Short.valueOf(colMetadata.getMinValue().toString()),
+ Short.valueOf(colMetadata.getMaxValue().toString()));
} else if (colType instanceof FloatType) {
return Pair.of(
- new Float(colMetadata.getMinValue().toString()),
- new Float(colMetadata.getMaxValue().toString()));
+ Float.valueOf(colMetadata.getMinValue().toString()),
+ Float.valueOf(colMetadata.getMaxValue().toString()));
} else if (colType instanceof BinaryType) {
return Pair.of(
((ByteBuffer) colMetadata.getMinValue()).array(),
diff --git
a/hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/functional/TestColStatsRecordWithMetadataRecord.java
b/hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/functional/TestColStatsRecordWithMetadataRecord.java
index 0db982b7447a..7e414b36b6ce 100644
---
a/hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/functional/TestColStatsRecordWithMetadataRecord.java
+++
b/hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/functional/TestColStatsRecordWithMetadataRecord.java
@@ -122,15 +122,15 @@ public class TestColStatsRecordWithMetadataRecord extends
HoodieSparkClientTestH
// Utf8
minMaxValues.add(Pair.of(new Utf8(getUTF8Bytes("abcdec")), new
Utf8(getUTF8Bytes("zyxwvu"))));
// Int
- minMaxValues.add(Pair.of(new Integer(-1000), new Integer(999999)));
+ minMaxValues.add(Pair.of(Integer.valueOf(-1000), Integer.valueOf(999999)));
// Long
- minMaxValues.add(Pair.of(new Long(-100000L), Long.MAX_VALUE));
+ minMaxValues.add(Pair.of(Long.valueOf(-100000L), Long.MAX_VALUE));
// boolean
minMaxValues.add(Pair.of(false, true));
// double
- minMaxValues.add(Pair.of(new Double(0.123), new Double(10.123)));
+ minMaxValues.add(Pair.of(Double.valueOf(0.123), Double.valueOf(10.123)));
// float
- minMaxValues.add(Pair.of(new Float(0.0123), new Float(200.123)));
+ minMaxValues.add(Pair.of(Float.valueOf(0.0123f), Float.valueOf(200.123f)));
// Date
minMaxValues.add(Pair.of(new Date(1000 * 60 * 60 * 10), new Date(1000 * 60
* 60 * 60)));
// LocalDate
@@ -332,15 +332,15 @@ public class TestColStatsRecordWithMetadataRecord extends
HoodieSparkClientTestH
ValueMetadata.V1EmptyMetadata.get());
// Float vals
- HoodieColumnRangeMetadata aFloatVal =
HoodieColumnRangeMetadata.create(fileName, colName, new Float(1), new
Float(1000.0), nullCount, valueCount, totalSize, totalUncompressedSize,
+ HoodieColumnRangeMetadata aFloatVal =
HoodieColumnRangeMetadata.create(fileName, colName, Float.valueOf(1),
Float.valueOf(1000.0f), nullCount, valueCount, totalSize, totalUncompressedSize,
ValueMetadata.V1EmptyMetadata.get());
- HoodieColumnRangeMetadata bFloatVal =
HoodieColumnRangeMetadata.create(fileName, colName, new Float(-1.0), new
Float(10000.0), nullCount, valueCount, totalSize, totalUncompressedSize,
+ HoodieColumnRangeMetadata bFloatVal =
HoodieColumnRangeMetadata.create(fileName, colName, Float.valueOf(-1.0f),
Float.valueOf(10000.0f), nullCount, valueCount, totalSize,
totalUncompressedSize,
ValueMetadata.V1EmptyMetadata.get());
// Double vals
- HoodieColumnRangeMetadata aDoubleVal =
HoodieColumnRangeMetadata.create(fileName, colName, new Double(0.1), new
Double(1000.0), nullCount, valueCount, totalSize, totalUncompressedSize,
+ HoodieColumnRangeMetadata aDoubleVal =
HoodieColumnRangeMetadata.create(fileName, colName, Double.valueOf(0.1),
Double.valueOf(1000.0), nullCount, valueCount, totalSize, totalUncompressedSize,
ValueMetadata.V1EmptyMetadata.get());
- HoodieColumnRangeMetadata bDoubleVal =
HoodieColumnRangeMetadata.create(fileName, colName, new Double(-1.0), new
Double(10000.0), nullCount, valueCount, totalSize, totalUncompressedSize,
+ HoodieColumnRangeMetadata bDoubleVal =
HoodieColumnRangeMetadata.create(fileName, colName, Double.valueOf(-1.0),
Double.valueOf(10000.0), nullCount, valueCount, totalSize,
totalUncompressedSize,
ValueMetadata.V1EmptyMetadata.get());
// String vals
@@ -402,43 +402,43 @@ public class TestColStatsRecordWithMetadataRecord extends
HoodieSparkClientTestH
// Float and Float
actualColumnRange = mergeAndAssert(aFloatVal, bFloatVal,
relativePartitionPath, colName, nullCount, totalSize, totalUncompressedSize,
HoodieSchemaType.FLOAT);
- assertEquals(new Float(-1), actualColumnRange.getMinValue());
- assertEquals(new Float(10000), actualColumnRange.getMaxValue());
+ assertEquals(Float.valueOf(-1), actualColumnRange.getMinValue());
+ assertEquals(Float.valueOf(10000), actualColumnRange.getMaxValue());
// Merging Float and Integer
actualColumnRange = mergeAndAssert(aFloatVal, bIntegerVal,
relativePartitionPath, colName, nullCount, totalSize, totalUncompressedSize,
HoodieSchemaType.FLOAT);
- assertEquals(new Float(-1), actualColumnRange.getMinValue());
- assertEquals(new Float(10000), actualColumnRange.getMaxValue());
+ assertEquals(Float.valueOf(-1), actualColumnRange.getMinValue());
+ assertEquals(Float.valueOf(10000), actualColumnRange.getMaxValue());
// Merging Float and Long.
actualColumnRange = mergeAndAssert(aFloatVal, bLongVal,
relativePartitionPath, colName, nullCount, totalSize, totalUncompressedSize,
HoodieSchemaType.FLOAT);
- assertEquals(new Float(-1), actualColumnRange.getMinValue());
- assertEquals(new Float(10000), actualColumnRange.getMaxValue());
+ assertEquals(Float.valueOf(-1), actualColumnRange.getMinValue());
+ assertEquals(Float.valueOf(10000), actualColumnRange.getMaxValue());
// Merging Float and String
actualColumnRange = mergeAndAssert(aFloatVal, bStringVal,
relativePartitionPath, colName, nullCount, totalSize, totalUncompressedSize,
HoodieSchemaType.FLOAT);
- assertEquals(new Float(-1), actualColumnRange.getMinValue());
- assertEquals(new Float(10000), actualColumnRange.getMaxValue());
+ assertEquals(Float.valueOf(-1), actualColumnRange.getMinValue());
+ assertEquals(Float.valueOf(10000), actualColumnRange.getMaxValue());
// Double and Double
actualColumnRange = mergeAndAssert(aDoubleVal, bDoubleVal,
relativePartitionPath, colName, nullCount, totalSize, totalUncompressedSize,
HoodieSchemaType.DOUBLE);
- assertEquals(new Double(-1), actualColumnRange.getMinValue());
- assertEquals(new Double(10000), actualColumnRange.getMaxValue());
+ assertEquals(Double.valueOf(-1), actualColumnRange.getMinValue());
+ assertEquals(Double.valueOf(10000), actualColumnRange.getMaxValue());
// Merging Double and Integer
actualColumnRange = mergeAndAssert(aDoubleVal, bIntegerVal,
relativePartitionPath, colName, nullCount, totalSize, totalUncompressedSize,
HoodieSchemaType.DOUBLE);
- assertEquals(new Double(-1), actualColumnRange.getMinValue());
- assertEquals(new Double(10000), actualColumnRange.getMaxValue());
+ assertEquals(Double.valueOf(-1), actualColumnRange.getMinValue());
+ assertEquals(Double.valueOf(10000), actualColumnRange.getMaxValue());
// Merging Double and Long.
actualColumnRange = mergeAndAssert(aDoubleVal, bLongVal,
relativePartitionPath, colName, nullCount, totalSize, totalUncompressedSize,
HoodieSchemaType.DOUBLE);
- assertEquals(new Double(-1), actualColumnRange.getMinValue());
- assertEquals(new Double(10000), actualColumnRange.getMaxValue());
+ assertEquals(Double.valueOf(-1), actualColumnRange.getMinValue());
+ assertEquals(Double.valueOf(10000), actualColumnRange.getMaxValue());
// Merging Double and String
actualColumnRange = mergeAndAssert(aDoubleVal, bStringVal,
relativePartitionPath, colName, nullCount, totalSize, totalUncompressedSize,
HoodieSchemaType.DOUBLE);
- assertEquals(0, actualColumnRange.getMinValue().compareTo(new Double(-1)));
- assertEquals(0, actualColumnRange.getMaxValue().compareTo(new
Double(10000)));
+ assertEquals(0,
actualColumnRange.getMinValue().compareTo(Double.valueOf(-1)));
+ assertEquals(0,
actualColumnRange.getMaxValue().compareTo(Double.valueOf(10000)));
}
private HoodieColumnRangeMetadata
mergeAndAssert(HoodieColumnRangeMetadata<Comparable> aVal,
HoodieColumnRangeMetadata<Comparable> bVal, String relativePartitionPath,
String colName, long nullCount,
