ashokraminedi commented on code in PR #20121:
URL: https://github.com/apache/hudi/pull/20121#discussion_r4215156307
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala:
##########
@@ -270,7 +270,15 @@ class HoodieSparkSqlWriterInternal {
(false, common.util.Option.empty(), common.util.Option.empty(),
common.util.Option.empty(), hoodieWriteClient.orNull, tableConfig)
} else {
// Handle various save modes
- handleSaveModes(sparkSession, mode, basePath, tableConfig, tblName,
operation, fs)
+ val saveModeOperation =
+ if (operation == WriteOperationType.BULK_INSERT
Review Comment:
Thanks for catching this! I've updated the condition to require
`ENABLE_ROW_WRITER` and added a regression test covering `BULK_INSERT` with the
row writer disabled.
The test verifies that `INSERT OVERWRITE TABLE` replaces existing records
rather than appending. Verified locally with the Spark 3.5 profile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
