nsivabalan commented on code in PR #19946:
URL: https://github.com/apache/hudi/pull/19946#discussion_r4225195925
##########
hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/RequestHandler.java:
##########
@@ -769,6 +770,11 @@ private boolean syncIfLocalViewBehind(Context ctx) {
if (isLocalViewBehind(ctx)) {
String lastKnownInstantFromClient = getLastInstantTsParam(ctx);
HoodieTimeline localTimeline =
viewManager.getFileSystemView(basePath).getTimeline();
+ // The final check already accepts a trailing clean with an
otherwise matching timeline.
+ // Other extensions still need a sync: restore may have deleted
their extra instants.
+ if (!shouldThrowExceptionIfLocalViewBehind(localTimeline,
getTimelineHashParam(ctx))) {
Review Comment:
can we move this to before L770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
