hudi-agent commented on code in PR #20310:
URL: https://github.com/apache/hudi/pull/20310#discussion_r4265228916


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -3998,6 +3994,11 @@ private void validate() {
             "Non-blocking concurrency control requires the MOR table with 
simple bucket index or it has to be Metadata table");
       }
 
+      
checkArgument(!writeConfig.getBooleanOrDefault(HoodieArchivalConfig.ARCHIVE_BEYOND_SAVEPOINT),

Review Comment:
   🤖 non-blocking: Flink readers also build a validated `HoodieWriteConfig` 
from the full table options (`MergeOnReadInputFormat#open`, `CdcInputFormat`, 
`AbstractSplitReaderFunction`). So a read-only Flink job whose DDL or catalog 
options still set this to true would now fail too, on the TaskManager at split 
open. Could the release note and the config doc say that reads fail as well, 
not just writes?
   
   <sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag 
quality.</i></sub>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to