yihua commented on code in PR #20309:
URL: https://github.com/apache/hudi/pull/20309#discussion_r4266951126
##########
hudi-io/src/main/java/org/apache/hudi/io/hfile/HFileCursor.java:
##########
@@ -34,7 +34,8 @@ public class HFileCursor {
private static final int INVALID_POSITION = -1;
- private int offset;
+ // Absolute position in the HFile, which can exceed Integer.MAX_VALUE for
files larger than 2GB
Review Comment:
nit: for compressed blocks this is the data block's file offset plus the
position in the uncompressed buffer rather than a byte position in the file.
Might be worth saying "block start offset in file + relative offset in the
uncompressed block" so the reason the (int) narrowing in HFileDataBlock is safe
(block sizes are int32 in the format) is visible from here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
