hudi-agent commented on code in PR #20324:
URL: https://github.com/apache/hudi/pull/20324#discussion_r4269423572
##########
hudi-hadoop-common/src/main/java/org/apache/parquet/avro/AvroSchemaConverterWithTimestampNTZ.java:
##########
@@ -368,10 +368,16 @@ private HoodieSchema convertFields(String name,
List<Type> parquetFields, Map<St
parquetType.getName(), fieldSchema, null, (Object) null));
}
}
- HoodieSchema schema = HoodieSchema.createRecord(name, null, nameCount > 1
? name + nameCount : null, false, fields);
+ HoodieSchema schema = HoodieSchema.createRecord(name, null, ns, false,
fields);
return schema;
}
+ // PARQUET-2456: repeated record and fixed names get a dedup namespace so
the schema survives toString and parse
+ private static String namespace(String name, Map<String, Integer> names) {
Review Comment:
🤖 nit: could you rename `namespace` to something like `nextDedupNamespace`?
It mutates `names` as a side effect, which the current name doesn't suggest.
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
