shangxinli commented on code in PR #20333:
URL: https://github.com/apache/hudi/pull/20333#discussion_r4272495582
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -2463,7 +2463,8 @@ public static Map<String, HoodieMetadataFileInfo>
combineFileSystemMetadata(Hood
return null;
}
return new HoodieMetadataFileInfo(
- Math.max(newFileInfo.getSize(), oldFileInfo.getSize()),
false);
+ Math.max(newFileInfo.getSize(), oldFileInfo.getSize()),
false,
+ newFileInfo.getSourceBasePath() != null ?
newFileInfo.getSourceBasePath() : oldFileInfo.getSourceBasePath());
Review Comment:
Followed up on this lambda again: preferring the newer record made the merge
order-dependent, which the note above it says it must not be, so it now takes
whichever side has the path set and warns if the two ever disagree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
