y2ksayed commented on PR #20334: URL: https://github.com/apache/hudi/pull/20334#issuecomment-6174285381
Thanks for the review! Addressed all three points in the latest commit: 1. **Version stability across archival**: versions are now resolved against the full commit history (archived + active timelines), so `VERSION AS OF N` keeps pointing at the same snapshot after archival runs. Archived instants always completed before active ones, so concatenating the two completion-ordered sequences yields the global order. 2. **Ordering and what counts as a version**: instants are now ordered by completion time instead of requested time — completion order is append-only, so a late-completing early-requested commit under multi-writer can no longer renumber already-issued versions. Kept `getCommitsTimeline()` (commit, delta-commit, replace-commit), documenting that clustering replace commits count as versions, mirroring Delta Lake where OPTIMIZE also bumps the table version. 3. **Nit**: dropped the redundant `.toString` (`asOfInstant.get`). @yihua — flagging for your take on the version semantics as requested: 0-indexed, completion-time ordered, stable across archival, replace commits included. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
