fhan688 commented on code in PR #20302:
URL: https://github.com/apache/hudi/pull/20302#discussion_r4281551190
##########
hudi-agent-gateway/skills/hudi-architect/validate_flink_design.py:
##########
@@ -483,17 +510,35 @@ def assess_design(
):
assessment.add(
"FLINK_DESIGN_CONTRACT_INVALID",
- "contract_schema must be 1 (append-only) or 2 (mutable COW)",
+ "contract_schema must be 1 (append-only), 2 (mutable COW), or 3
(mutable MOR)",
)
- mutable_contract = contract_schema == MUTABLE_CONTRACT_SCHEMA_VERSION
- contract_profile = manifest[
- "mutable_executable_contract" if mutable_contract else
"executable_contract"
- ]
+ mutable_contract = contract_schema in {
Review Comment:
Thanks for catching this. I added an explicit type guard before the schema
membership checks and covered array/object `contract_schema` values. They now
return a structured `FLINK_DESIGN_CONTRACT_INVALID` assessment without a
traceback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
