hudi-agent commented on code in PR #20350:
URL: https://github.com/apache/hudi/pull/20350#discussion_r4283030152
##########
hudi-client/hudi-java-client/src/main/java/org/apache/hudi/client/HoodieJavaWriteClient.java:
##########
@@ -248,7 +248,9 @@ private void initializeMetadataTable(Option<String>
inFlightInstantTimestamp, Ho
if (writer.hasPartitionsStateChanged()) {
metaClient.reloadTableConfig();
}
- writer.performTableServices(inFlightInstantTimestamp);
+ if (config.getMetadataConfig().isInlineTableServicesEnabled()) {
Review Comment:
🤖 non-blocking: It looks like nothing tests this Java client check, since
the new tests only cover Spark and Flink, so removing it wouldn't fail
anything; could you add a small case next to `TestJavaHoodieBackedMetadata`
that mirrors `TestSparkDeletePartitionTableServices`?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java:
##########
@@ -100,6 +100,15 @@ public final class HoodieMetadataConfig extends
HoodieConfig {
+ "instead of executing them inline. This prevents the current
writer from executing compaction/logcompaction "
+ "on the metadata table, allowing a separate async pipeline to
handle them.");
+ public static final ConfigProperty<Boolean> INLINE_TABLE_SERVICES_ENABLED =
ConfigProperty
+ .key(METADATA_PREFIX + ".inline.table.services.enabled")
+ .defaultValue(true)
+ .markAdvanced()
+ .sinceVersion("1.3.0")
+ .withDocumentation("If false, a data table writer does not run clean,
compaction or archival on the metadata table "
+ + "inline. For jobs that must not maintain the metadata table, such
as a partition delete, "
Review Comment:
🤖 nit: could you reword the second sentence of this doc? "For jobs that must
not maintain the metadata table ... and that leave it to ..." reads as a
fragment, e.g. "Useful for jobs such as partition delete that should not
maintain the metadata table and leave that to regular writers or a table
service platform."
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
