wombatu-kun commented on code in PR #20366:
URL: https://github.com/apache/hudi/pull/20366#discussion_r4293851965
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/FileGroupReaderBasedInlineLogAppendHandle.java:
##########
@@ -116,6 +117,18 @@ public void doAppend() {
}
}
+ /**
+ * The file group reader holds ordering values in the engine type. A delete
is written back into a delete block,
+ * which only stores Java types, so its ordering value is converted back.
+ */
+ private BufferedRecord<T> withJavaOrderingValue(BufferedRecord<T> record) {
+ if (!record.isDelete()) {
+ return record;
+ }
Review Comment:
Done b050060b85ae: the inline handle no longer has this helper, and the one
left in the native handle holds a `Comparable<?>`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
