skywalker0618 commented on code in PR #20165:
URL: https://github.com/apache/hudi/pull/20165#discussion_r4297185238
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteOperatorCoordinator.java:
##########
@@ -465,7 +467,9 @@ private void initHiveSync() {
.waitForTasksFinish(true).build();
this.hiveSyncContext = HiveSyncContext.create(conf, this.storageConf);
this.hiveSyncMetrics = new FlinkHiveSyncMetrics(context.metricGroup());
- this.hiveSyncMetrics.registerMetrics();
+ if (FormatUtils.getBooleanWithAltKeys(conf,
HiveSyncConfigHolder.HIVE_SYNC_STATS_ENABLED)) {
Review Comment:
Having a second thought, I think we should indeed keep the original 4, and
gate only the new ones. Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
