shangxinli commented on code in PR #20341:
URL: https://github.com/apache/hudi/pull/20341#discussion_r4297507154
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/BaseSparkInternalRecordContext.java:
##########
@@ -124,7 +124,7 @@ public String getMetaFieldValue(InternalRow record, int
pos) {
@Override
public HoodieRecord<InternalRow>
constructHoodieRecord(BufferedRecord<InternalRow> bufferedRecord, String
partitionPath) {
HoodieKey hoodieKey = new HoodieKey(bufferedRecord.getRecordKey(),
partitionPath);
- if (bufferedRecord.isDelete()) {
+ if (bufferedRecord.isDelete() && bufferedRecord.isEmpty()) {
Review Comment:
**major:** Two other sites need the same guard and still have the bare
`isDelete()`: `HiveRecordContext:85` and
`AvroRecordContext.constructFinalHoodieRecord:136`, so the Hive and generic
Avro merge paths keep dropping the payload (`FlinkRecordContext:142` and
`AvroRecordContext.constructHoodieRecord:120` already have it). The new test
only runs `HoodieRecordType.SPARK`, so CI will not catch them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
