shangxinli commented on code in PR #20282:
URL: https://github.com/apache/hudi/pull/20282#discussion_r4297506819
##########
hudi-common/src/main/java/org/apache/hudi/common/model/MetaFieldsMode.java:
##########
@@ -184,9 +184,12 @@ private static MetaFieldsMode parse(String rawMode) {
/**
* @return the equivalent value of the deprecated {@code
hoodie.populate.meta.fields} boolean, so
* that call sites not yet migrated to this enum keep observing consistent
behavior.
+ *
+ * <p>Only {@link #NONE} maps to {@code false}: the boolean says whether any
meta column is
+ * populated, not which. Use {@link #isRecordKeyPopulated()} for
key-dependent checks.
*/
public boolean toLegacyPopulateMetaFields() {
- return this == ALL;
+ return this != NONE;
Review Comment:
**major:** isRecordKeyPopulated() is still this == ALL, so this flip
contradicts it and leaves the ~40 legacy-boolean call sites unmigrated -
BaseHoodieLogRecordReader:192 then keys off _hoodie_record_key on a
COMMIT_TIME_ONLY table. It also persists: HoodieTableConfig.create():702 now
writes hoodie.populate.meta.fields=true for those tables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
