nsivabalan commented on code in PR #20385: URL: https://github.com/apache/hudi/pull/20385#discussion_r4346429809
########## hudi-ai-operator/skills/hudi-table-health/SKILL.md: ########## @@ -68,9 +68,12 @@ java -cp "$HUDI_UTILITIES_BUNDLE" org.apache.hudi.utilities.HoodieTableHealthChe --output JSON ``` -Always request `--output JSON`. Capture the exit code as well as stdout: `0` healthy, `1` unhealthy, -`2` the tool could not run (bad arguments, unreadable table, or a check that threw). On `2`, read -the `errors` array and stderr before saying anything about the table. +Always request `--output JSON`. Capture the exit code as well as stdout: `0` every check healthy or +skipped, `3` at least one check UNHEALTHY, `4` no check unhealthy but at least one could not run, +`2` the tool itself could not run (bad arguments or an unreadable table). There is no exit code `1`: Review Comment: Good catch — yes, `JCommander` is built outside `main`'s `try`, so a `ParameterException` escapes with exit `1`. Took the doc route here in c61e18d: the paragraph now says a rejected command line (no arguments, missing `--base-path`, unknown flag) also exits `1` today, and that `1` always means "the tool did not run", never a verdict. Mapping it to `EXIT_ERROR` in `main` is a small code change I'd rather do as a follow-up so this stays doc-only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
