danny0405 commented on code in PR #20412:
URL: https://github.com/apache/hudi/pull/20412#discussion_r4374113808
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala:
##########
@@ -533,7 +568,7 @@ class HoodieSparkSqlWriterInternal {
// scalastyle:on
val writeConfig = client.getConfig
- instantTime = client.startCommit(commitActionType)
+ instantTime = recordStartedInstant(client,
client.startCommit(commitActionType))
Review Comment:
Addressed in 2c4f041d334695f3bdff640bbf7c8f1f16be67d1. `startCommit` now
catches failures while the allocated instant is still known and stops only that
instant's heartbeat, preserving the original exception (cleanup errors are
suppressed). Four regression cases inject failures before/after persisting
commit and replace-commit instants, assert another live heartbeat is
unaffected, and reuse the same client for the next commit. The fix has also
been carried through #20413 and #20415. On the final stack, all 147 related
Java tests passed with JDK 17 and UTC; Checkstyle and RAT passed. The full
Spark integration suite was not rerun.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
