yihua commented on code in PR #623: URL: https://github.com/apache/hudi-rs/pull/623#discussion_r4395411880
########## python/pyproject.toml: ########## @@ -87,6 +87,7 @@ exclude = "^tests" strict = true [tool.pytest.ini_options] +addopts = "--doctest-modules" Review Comment: non-blocking: the CI job runs `pytest -v` from the repo root, where this pyproject isn't picked up, so the doctests will run under `make test-python` but not in CI. Not something to fix here, just noting it so the flag isn't assumed to be live after merge. ########## python/pyproject.toml: ########## @@ -87,6 +87,7 @@ exclude = "^tests" strict = true [tool.pytest.ini_options] +addopts = "--doctest-modules" Review Comment: Done: pushed a commit on this branch pointing CI at `pytest -v python`, which collects the eleven doctests alongside the existing tests (84 collected instead of 73), and rebased onto main so the workflows run on the current runner image. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
