yihua opened a new issue, #861:
URL: https://github.com/apache/hudi-rs/issues/861

   ## Summary
   
   `crates/core/src/write/append.rs` holds the append verb and also most of the 
writer's shared helpers: instant generation and the commit timezone flag, 
parquet writer properties and encoding, the Arrow to Avro schema conversion, 
meta-field schema helpers and timeline path helpers. `rewrite`, `metadata`, 
`rollback`, `sizing` and `write/mod.rs` reach them through 
`crate::write::append::*`, so a change to a shared helper reads as an append 
change and the append module is hard to follow.
   
   ## Proposal
   
   Move the shared helpers into modules named for what they do (for example 
instant generation, parquet encoding and schema conversion under `write/`), 
leaving `append.rs` with the append verb only. A pure move with no behavior 
change; #857 (per-table instant generation) touches the same code and could 
land first.
   
   Raised in the #666 review follow-up list (item 13).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to