yihua opened a new pull request, #877:
URL: https://github.com/apache/hudi-rs/pull/877

   ## Description
   
   closes #876
   
   On timeline layout v2 an incremental read's start and end bounds are 
compared against commit completion times, but a write returned only the 
instant's requested time, so a caller could not ask for "what changed after my 
write" without including the write itself. `WriteResult` and `AppendResult` now 
carry `completion_time`, taken from the same value `complete_write` writes into 
the completed instant; it is `None` on layout v1 and when a write makes no 
commit.
   
   ## How are the changes test-covered
   
   - [ ] N/A
   - [x] Automated tests (unit and/or integration tests)
   - [ ] Manual tests
     - [ ] Details are described below
   
   `test_write_result_completion_time_matches_timeline` checks that append, 
upsert and a committing delete each return the completion time recorded on the 
timeline, on copy-on-write and merge-on-read, and that a delete matching 
nothing returns `None`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to