yihua commented on PR #851: URL: https://github.com/apache/hudi-rs/pull/851#issuecomment-6508631381
Pushed a round of review fixes (62395e23..79f3c29a): - **CI:** the `.properties` fixtures moved under `tests/data/`, which the license header check skips. - **Rollback:** the failed instant's fencing files are deleted before the rollback completes, as Java's `finishRollback` does, so a failed delete leaves the rollback pending and the next write resumes it instead of writing a second one. - **MOR keyed deletes:** a key requested in a partition it isn't stored in matches nothing, as on COW, and a key stored in two partitions is deleted from each partition the delete names (one copy used to survive). - **Create:** `hoodie.table.index.defs.path` is refused in `with_option`, since the definition always goes to the default path. - **Bloom footer:** the min/max record keys use Java's `String.compareTo` order, which `BloomIndexFileInfo.isKeyInRange` checks against. - **Layering and cleanup:** the reader and archival share one LSM history folder resolver, input normalization takes its types from the commit schema's Avro round trip, record index millis go through one zone-aware helper, archival retires one stale manifest per publish and projects only `instantTime` on retry, and the unused `column_stats_tombstones` is gone. - **Tests:** archival's stop at the first failed delete, distinct clean plan bytes, a discriminating default-partition filter, and the write model now picks partial updates with and without the ordering field. Left as is: the append vs upsert schema check split is tracked in #867. MOR inserts stay in new base files because Java's SIMPLE and BLOOM indexes read base files only and the record index can be turned off later. `TimelineTimezoneValue` keeps its released `utc`/`local` strings, with the Java spelling used only when persisting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
