wombatu-kun commented on code in PR #20474:
URL: https://github.com/apache/hudi/pull/20474#discussion_r4419914176
##########
.asf.yaml:
##########
@@ -45,18 +45,48 @@ github:
required_pull_request_reviews:
required_approving_review_count: 1
required_status_checks:
+ # The merge queue tests each PR against the latest master, so PRs need
not be up to date.
strict: false
contexts:
- # The per-job test contexts are no longer required individually.
Listing them here
- # is what made every change to the CI matrix in
.github/workflows/bot.yml a
- # two-sided edit, and a context left without a job to report it
blocks merges
- # indefinitely. Reviewers gate on the checks the PR shows.
- # Only contexts from always-on workflows may be listed. bot.yml and
- # java_ci_engines.yml are path-filtered: on a PR the filter skips,
GitHub never
- # instantiates them, so any context of theirs would stay pending
forever
- # (#18598 hit exactly this and worked around it with a gating job).
- # validate-pr-and-source runs the PR metadata and source release
checks in one job
+ # Only contexts that report on every PR and every merge-queue group
may be listed: a
+ # context left without a run to report it blocks merges indefinitely
(#18598).
+ # The per-job test contexts are not listed. Required Checks in
ci.yml aggregates
+ # bot.yml and java_ci_engines.yml, so resharding their jobs never
touches this file.
+ # validate-pr-and-source runs the PR metadata and source release
checks in one job.
- validate-pr-and-source
+ - Required Checks
+ # Raw GitHub Rulesets API payload, as in apache/arrow-rs and
apache/datafusion-comet.
+ # Rulesets and classic branch protection apply together.
+ rulesets:
+ - name: Merge Queue
+ target: branch
+ enforcement: active
+ bypass_actors:
Review Comment:
Master's first Java CI attempt failed on 15 of 151 commits since
mid-September, 6 of them flakes that went green on a re-run, and a failed entry
leaves the queue with only apache/root able to bypass it. Is re-queueing the
intended answer there, or should Hudi committers get a `bypass_mode:
pull_request` entry next to apache/root, as iceberg-rust has for its committers?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
