fhan688 commented on code in PR #20472:
URL: https://github.com/apache/hudi/pull/20472#discussion_r4421157842
##########
hudi-ai-operator/skills/hudi-architect/validate_flink_design.py:
##########
@@ -1303,13 +1310,11 @@ def assess_design(
writer_model = safety.get("writer_model")
if writer_model is None:
assessment.add("FLINK_WRITER_MODEL_UNRESOLVED", "Writer topology is
required")
- elif writer_model == "multi_writer":
- assessment.add(
- "FLINK_MULTI_WRITER_REVIEW",
- "The executable contracts support only a confirmed single writer",
- )
- elif writer_model != "single_writer":
+ elif writer_model not in {"single_writer", "multi_writer"}:
Review Comment:
Thanks for catching the regression. I added an explicit string type guard
before the membership check. List and object values now return
`FLINK_WRITER_MODEL_UNRESOLVED` without a traceback in both design and
reconciliation paths, with regression tests included.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
