shangxinli commented on code in PR #18817:
URL: https://github.com/apache/hudi/pull/18817#discussion_r4425844942
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/StorageBasedLockProvider.java:
##########
@@ -194,8 +195,8 @@ private static Functions.Function3<String, String,
TypedProperties, StorageLockC
StorageBasedLockConfig config = new
StorageBasedLockConfig.Builder().fromProperties(properties).build();
long heartbeatPollSeconds = config.getRenewIntervalSecs();
this.lockValiditySecs = config.getValiditySeconds();
- this.basePath = config.getHudiTableBasePath();
- String lockFolderPath = StorageLockClient.getLockFolderPath(basePath);
+ this.normalizedHudiTableBasePath =
normalizeBasePathForLocking(config.getHudiTableBasePath());
Review Comment:
Unlike the DynamoDB and Zookeeper providers in this same stack, this
constructor doesn't log the raw and normalized base path, so there's no signal
in logs that a writer still on the old release would be locking on a different
path and not be mutually excluded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
