slachiewicz opened a new pull request, #976:
URL: https://github.com/apache/hudi-rs/pull/976

   ## Description
   
   Adds unit tests for `TimestampBasedKeyGenerator` and `PartitionPruner` paths 
that had none:
   scalar time units, invalid input and output timezones, epoch and scalar 
literals beyond the
   datetime range, the parse-time guards for an unset input format or scalar 
unit, ambiguous
   wall-clock times around DST, `is_table_partitioned` with the non-partitioned 
key generator
   class and type, and the fail-open arms of `should_include`. No production 
code changes.
   
   Split out of #724 at review. The tests build `TimestampBasedKeyGenerator` and
   `PartitionPruner` as struct literals and call `parse_timestamp` directly, so 
they track
   main's internals: #724 removes `partition_fields`, #725 adds two pruner 
fields, and #746
   moves the source-encoded parse to `parse_source_encoded`. Whichever lands 
second adjusts
   those lines.
   
   Verified: `cargo test -p hudi-core --lib -- table::partition keygen expr 
config` passes, and
   `cargo fmt --all -- --check` and `cargo clippy -p hudi-core --all-targets -- 
-D warnings` are
   clean locally.
   
   ## How are the changes test-covered
   
   - [ ] N/A
   - [x] Automated tests (unit and/or integration tests)
   - [ ] Manual tests
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to