yihua opened a new pull request, #986:
URL: https://github.com/apache/hudi-rs/pull/986

   ## Description
   
   An incremental read of a table with `hoodie.populate.meta.fields=false` 
skipped the commit-time mask, since there is no `_hoodie_commit_time` to filter 
by, and returned every row of each file slice the window touched. 
`Table::prepare_reader_options` now refuses an incremental query on such a 
table with `Unsupported`, matching Java's `IncrementalRelationV1/V2` and 
`MergeOnReadIncrementalRelationV1/V2`; `read`, `read_stream`, `get_file_slices` 
and `create_file_group_reader_with_options` all pass through it. This also 
applies to version 6 tables that hudi-rs appended to (they require meta fields 
off), whose incremental reads previously returned results; the existing 
append-only test is updated to expect the refusal. The reader spec notes the 
new error.
   
   Closes #918
   
   ## How are the changes test-covered
   
   - [ ] N/A
   - [x] Automated tests (unit and/or integration tests)
   - [ ] Manual tests
     - [ ] Details are described below
   
   `test_refused_without_meta_fields` runs on the existing v6 (COW and MOR) and 
v8 (COW) meta-off fixtures and asserts `Unsupported` from all four entry points 
while a snapshot read still returns rows; on main those incremental reads are 
not refused.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to