yihua opened a new pull request, #993:
URL: https://github.com/apache/hudi-rs/pull/993

   ## Description
   
   closes #992
   
   `new_metadata_table` now opens `.hoodie/metadata` with the data table's 
resolved storage options, so credentials, region or an endpoint passed as 
options reach the metadata table too. Without them, the open failed whenever 
those settings weren't also in the environment: planning fell back to storage 
listing and retried the open on every plan. The options go in through 
`with_storage_options`, so they stay storage options, and env vars still fill 
in only the keys that are missing. This edits the same function as #989, so 
whichever lands second needs a small rebase.
   
   ## How are the changes test-covered
   
   - [ ] N/A
   - [x] Automated tests (unit and/or integration tests)
   - [x] Manual tests
     - [x] Details are described below
   
   `new_metadata_table_opens_with_data_table_storage_options` passes a storage 
option that no env var supplies and checks that the metadata table has it. The 
test fails without the fix. Manually, on an S3 table outside `us-east-1` with 
the region passed only as an option and no region in the environment, 
`new_metadata_table` fails on main with a region redirect and succeeds with 
this change.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to