skywalker0618 commented on code in PR #20564:
URL: https://github.com/apache/hudi/pull/20564#discussion_r4532744903
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/reader/HoodieSourceSplitReader.java:
##########
@@ -181,6 +186,7 @@ public void close() throws Exception {
private RecordsWithSplitIds<HoodieRecordWithPosition<T>> finishSplit() {
RecordsWithSplitIds<HoodieRecordWithPosition<T>> records =
BatchRecords.lastBatchRecords(currentSplit.splitId());
currentSplit = null;
+ readerMetrics.clearCurrentSplit();
Review Comment:
Agreed, fixed in bc41326be5. `FlinkStreamReadMetrics` now tracks the active
splits by id (`startSplit` / `finishSplit`), and
`HoodieSourceReader.onSplitFinished` finishes them, on the task thread after
all of the split's records are emitted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]