ravjot28 opened a new pull request, #20616:
URL: https://github.com/apache/hudi/pull/20616

   ### Describe the issue this Pull Request addresses
   
   Closes #20610
   
   `HoodieMetadataWriteUtils#createMetadataWriteConfig` does not copy 
`hoodie.client.heartbeat.interval_in_ms` and
   `hoodie.client.heartbeat.tolerable.misses` from the data table write config, 
so the metadata table writer always
   uses the default heartbeat lease. That lease decides when a pending metadata 
table write counts as failed in the
   modes where the metadata table cleans failed writes lazily: streaming 
metadata writes and metadata table multi-writer
   mode.
   
   ### Summary and Changelog
   
   The metadata table writer uses the heartbeat interval and tolerable misses 
configured for the data table.
   
   - `HoodieMetadataWriteUtils#createMetadataWriteConfig` sets both values from 
the data table write config.
   - New test 
`TestHoodieMetadataWriteUtils#testCreateMetadataWriteConfigPropagatesHeartbeatSettings`.
   
   ### Impact
   
   No API or config change. Tables that set non-default heartbeat values now 
use them for the metadata table too;
   tables on the defaults see no difference.
   
   **Backport:** please include this fix in the next 1.2.x patch release. The 
main change cherry-picks cleanly onto `release-1.2.1` and `branch-1.2.x`; the 
test file conflicts there and needs the new test placed by hand.
   
   ### Risk Level
   
   low. Two configuration values copied, as the method already does for other 
client settings.
   
   Tests, run on master with JDK 11 and passing checkstyle checks for main and 
test sources, with
   `mvn test -pl hudi-client/hudi-client-common -am 
-Dtest=TestHoodieMetadataWriteUtils`:
   - Without the main code change: 
`testCreateMetadataWriteConfigPropagatesHeartbeatSettings` fails with
     `expected: <5000> but was: <60000>`.
   - With the change: `TestHoodieMetadataWriteUtils` 30/30 pass.
   
   ### Documentation Update
   
   none
   
   ### Contributor's checklist
   
   - [x] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [x] Enough context is provided in the sections above
   - [x] Adequate tests were added if applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to