danny0405 commented on code in PR #20654:
URL: https://github.com/apache/hudi/pull/20654#discussion_r4559467191
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/format/FlinkRowDataReaderContext.java:
##########
@@ -113,8 +113,11 @@ public ClosableIterator<RowData> getFileRecordIterator(
.getReaderFactory(HoodieRecord.HoodieRecordType.FLINK)
.getFileReader(tableConfig, filePath, format, Option.empty());
try {
+ // Native delete logs may omit business key columns, so query predicates
can discard tombstones needed for merging.
+ List<ExpressionPredicates.Predicate> predicates =
FSUtils.isNativeDeleteLogFile(filePath.getName())
Review Comment:
-1 by myself, we should not filter in singe files, it will make the merging
semantics broken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]