nsivabalan commented on PR #20445:
URL: https://github.com/apache/hudi/pull/20445#issuecomment-6934804298

   @danny0405 thanks for the third round. All three comments are addressed in 
183b787f (replies inline):
   - A heartbeat deleted between `exists()` and `getPathInfo()` counts as 
expired, followed by the pending re-check.
   - Graceful shutdown wakes the heartbeat wait immediately.
   - `isPendingInstant` uses the supplied client, and the forwarders are 
removed.
   - Instants that are no longer pending skip the wait entirely.
   
   I also rebased onto current master to resolve the conflict with #20429. 
#20429 added the same failure recording to `HoodieAsyncService`, so I kept 
master's `recordFailure` and added only the shutdown hook this PR needs. 
#20429's `TestAsyncTableServiceFailure` overrode the old single-argument 
`compact`/`cluster`, so I updated it to the two-argument signatures.
   
   Local: the `TestAsyncTableService*` suites (Retry 14/14 incl. 3 new 
regression tests, Failure 4/4, ClientHandoff 2/2) and `TestStructuredStreaming` 
29/29; checkstyle clean. The async-service suites were re-run on the latest 
master after the final rebase.
   
   @shangxinli your bounded-retry thread is settled too, thanks.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to