cshuo commented on code in PR #20671:
URL: https://github.com/apache/hudi/pull/20671#discussion_r4596230821
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/io/storage/hadoop/HoodieAvroFileWriterFactory.java:
##########
@@ -170,7 +172,8 @@ protected HoodieFileWriter newHFileFileWriter(
protected HoodieFileWriter newOrcFileWriter(
String instantTime, StoragePath path, HoodieConfig config, HoodieSchema
schema,
TaskContextSupplier taskContextSupplier) throws IOException {
- BloomFilter filter = createBloomFilter(config);
+ // bloom indexes only consume base files; native ORC log readers do not
use this filter.
+ BloomFilter filter = FSUtils.isNativeLogFile(path.getName()) ? null :
createBloomFilter(config);
Review Comment:
No, the ORC path calls newOrcFileWriter directly without going through
enableBloomFilter. It previously created the bloom filter unconditionally. This
separate check disables it only for native logs while preserving the existing
ORC base-file behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]