wombatu-kun commented on code in PR #19933:
URL: https://github.com/apache/hudi/pull/19933#discussion_r4601401787


##########
.github/workflows/bot.yml:
##########
@@ -325,6 +325,13 @@ jobs:
           FLINK_PROFILE: ${{ matrix.flinkProfile }}
         run:
           mvn test -Pfunctional-tests -D"$SCALA_PROFILE" -D"$SPARK_PROFILE" 
-D"$FLINK_PROFILE" -fae -Dsurefire.failIfNoSpecifiedTests=false -pl 
hudi-utilities $MVN_ARGS -Djacoco.skip=false
+      - name: UT - hudi-hadoop-mr and hudi-client/hudi-java-client

Review Comment:
   The default `success()` condition skips the Hadoop MR and Java client tests 
after a utilities test failure, although they previously ran in an independent 
job. Use the build step's outcome to run this step after utilities failures 
while still skipping it when the build fails.



##########
.github/workflows/bot.yml:
##########
@@ -335,7 +342,7 @@ jobs:
         if: always() && github.event_name != 'merge_group'
         uses: ./.github/actions/upload-coverage
         with:
-          flags: utilities
+          flags: utilities,hadoop-mr-java-client

Review Comment:
   This upload assigns the combined utilities, Hadoop MR, and Java client 
report to both flags, so each flag now reports the union instead of its 
previous suite-specific coverage. Generate and upload separate reports for 
`utilities` and `hadoop-mr-java-client` to preserve the flag scopes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to