Davis-Zhang-Onehouse opened a new pull request, #20700:
URL: https://github.com/apache/hudi/pull/20700

   ### Describe the issue this Pull Request addresses
   
   issue: #20699
   Part of #20683, RFC-118 (#20684).
   Stacked on #20698: review only the last commit. Until the PRs below it 
merge, this PR also shows their commits.
   
   Adds the embedding compute core and the `prep_only` embedding transformer, 
which make `UnstructuredDataSource` usable in embedding mode for the first time.
   
   ### Summary and Changelog
   
   - `EmbeddingTableTransformer` and `PrepRound`: the `prep_only` round turns 
source files into chunk rows of the embedding table.
   - Compute core: `ComputeRound`, `MicroBatchEmbeddingIterator`, 
`EmbeddingClientFactory`, `ProviderClientSettings`, `ProviderRetryLoop`, 
`ProviderResponseKind`, `RequestRateLimiter`, `EmbeddingCallStats`, 
`ComputeCounters`, and the compute exceptions (platform, transient, provider 
unavailable).
   - `UnstructuredDataSource`, `UnstructuredMode`, `UnstructuredSourceConfig`, 
`UnstructuredSourceContract`, `UnstructuredSchemaContract`, 
`UnstructuredSchemaGuard`, `BlobSourceSetup`: embedding mode, its required 
transformer chain and settings. The transformer refuses `prep_and_compute` 
until the compute round lands later in this chain.
   - `PreprocessorRegistry.validateConfig`: validates each preprocessor's 
configuration on the driver.
   - 26 test files.
   
   Only files added earlier in this chain are modified; no existing Hudi file 
changes. No code was copied from other projects.
   
   Known limitation, fixed later in this chain before it completes: for files 
that yield no chunk, the prep round can queue one side-output record per file 
before it yields its first row, so a long run of such files is held in memory.
   
   ### Impact
   
   `UnstructuredDataSource` gains embedding mode with `prep_only`. Existing 
sources and transformers are unaffected.
   
   ### Risk Level
   
   medium: new transformer in the Streamer write path of the new source only. 
Verified on JDK 11 / Spark 3.5 / Scala 2.12 with 98 tests, module compilation, 
checkstyle and RAT.
   
   ### Documentation Update
   
   New settings carry their config documentation. RFC-118 describes the 
embedding modes; a website page follows once the chain lands.
   
   ### Contributor's checklist
   
   - [x] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [x] Enough context is provided in the sections above
   - [x] Adequate tests were added if applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

  • [PR] feat(ingest): RFC-118: ... Davis-Zhang-Onehouse (via GitHub) via commits

Reply via email to