voonhous commented on PR #20766: URL: https://github.com/apache/hudi/pull/20766#issuecomment-7028408657
Good catch on the two partitioners. I had skipped them because they log through the log4j2 API (`LogManager.getLogger`) rather than SLF4J, but they are the only main-source classes still doing that, so moving them to `@Slf4j` fits here. Both are migrated now with the same logger category, and nothing else referenced their `LOG` fields. `HoodieSparkKryoRegistrar` is Scala. Lombok is a javac annotation processor and scalac does not run it, so `@Slf4j` has no effect on Scala classes. It already uses an SLF4J `private val log`, so there is nothing to migrate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
