NestDream commented on code in PR #20776:
URL: https://github.com/apache/hudi/pull/20776#discussion_r4649024551
##########
hudi-examples/hudi-examples-flink/src/main/java/org/apache/hudi/examples/quickstart/HoodieFlinkQuickstart.java:
##########
@@ -114,6 +114,9 @@ public void initEnv() {
// configure not to retry after failure
execConf.setString("restart-strategy", "fixed-delay");
execConf.setString("restart-strategy.fixed-delay.attempts", "0");
+ // Flink 2.3 rejects an INSERT whose upsert key differs from the primary
key of the sink table
+ // unless it has an ON CONFLICT clause (FLINK-38927), restore the
behavior of earlier versions.
+ execConf.setString("table.exec.sink.require-on-conflict", "false");
Review Comment:
@cshuo Makes sense, done. `getChangelogMode` now uses your snippet, and I
removed the `require-on-conflict` setting from the quickstart, the tests and
`insert.sql`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]